Fix simulation id validation #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlefaudeux
reviewed
Jun 26, 2024
R/utilities-simulation.R
Outdated
|
|
||
| # Validate that simulationId is idnetical with piParamIds and outputMappingIds | ||
| if (!identical(simulationIds, piParamIds) || !identical(simulationIds, outputMappingIds)) { | ||
| stop(messages$errorSimulationIdMissing(id)) |
R/utilities-simulation.R
Outdated
| piParamIds <- sort(piParamIds) | ||
| outputMappingIds <- sort(outputMappingIds) | ||
|
|
||
| # Validate that simulationId is idnetical with piParamIds and outputMappingIds |
There was a problem hiding this comment.
Suggested change
| # Validate that simulationId is idnetical with piParamIds and outputMappingIds | |
| # Validate that simulationId is identical with piParamIds and outputMappingIds |
|
Also fixes #137 |
dlefaudeux
approved these changes
Jul 4, 2024
Felixmil
approved these changes
Jul 4, 2024
PavelBal
reviewed
Jul 5, 2024
| outputMappingIds <- sort(outputMappingIds) | ||
|
|
||
| # Validate that simulationId is identical with piParamIds and outputMappingIds | ||
| if (!identical(simulationIds, piParamIds) || !identical(simulationIds, outputMappingIds)) { |
There was a problem hiding this comment.
When could this happen? How could the user invoke this behavior? @rengelke
There was a problem hiding this comment.
If the user forget data or parameters or simulations in the ParameterIdentification$new(), for example.
cf added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127 where validation did not consider that piParams can have multiple levels